Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execute mode #16298

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add execute mode #16298

wants to merge 1 commit into from

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 17, 2023

These files are scripts and on macOS one would expect to be able to run them without needing to do additional work...

@jsoref jsoref requested a review from a team as a code owner November 17, 2023 14:02
@jsoref jsoref marked this pull request as draft November 17, 2023 14:03
*.sh
*.pl

Signed-off-by: Josh Soref <[email protected]>
@vzarytovskii
Copy link
Member

eng/common are managed by arcade, we don't touch those.

@@ -1,4 +1,4 @@
# run.pl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl scripts don't run on non-windows machines, so while change is correct, it makes a very little sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants