Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrimStart and TrimEnd with optional char array implementation for SQL Server #33715

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

abdielcs
Copy link

Fixes #22924

  • [X ] I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • [ X] The code builds and tests pass locally (also verified by our automated build checks)
  • [X ] Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • [X ] Tests for the changes have been added (for bug fixes / features)
  • [X ] Code follows the same patterns and style as existing code in this repo

@abdielcs
Copy link
Author

@dotnet-policy-service agree

@roji
Copy link
Member

roji commented May 17, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts:
#	src/EFCore.SqlServer/Query/Internal/SqlServerMethodCallTranslatorProvider.cs
@cincuranet
Copy link
Contributor

@maumar or @roji can I get 2nd set of eyes. Otherwise LGTM.

@cincuranet cincuranet requested review from maumar and roji May 24, 2024 15:36
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here are some comments from me.

Note that there's also #22927 for Trim (as opposed to TrimStart/End) - it would be good to add this translation too (though it doesn't have to happen in the same PR).

…RTRIM. Handling compatibility level to low."

This reverts commit e1a73e7.
# Conflicts:
#	src/EFCore.SqlServer/Query/Internal/SqlServerMethodCallTranslatorProvider.cs
@abdielcs
Copy link
Author

Thanks, here are some comments from me.

Note that there's also #22927 for Trim (as opposed to TrimStart/End) - it would be good to add this translation too (though it doesn't have to happen in the same PR).

Yes, I saw the Trim, but since it has a different syntax in the new version, it is unlikely that it can be done in the same way. So, @roji, if you agree, I would prefer to address it after finishing these.

For some reason, my SQLite tests are failing again. Maybe I'm doing something wrong in the merge or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

string.TrimStart not working in where
3 participants