Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix nightly build errors #9920

Merged
merged 1 commit into from
May 16, 2024

Conversation

filzrev
Copy link
Contributor

@filzrev filzrev commented May 14, 2024

This PR is successor of #9913.

On latest nightly CI build.
Following errors are occurred additionally .

Error: /usr/share/dotnet/sdk/9.0.100-preview.3.24204.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error PKV006: Target framework net6.0 is no longer supported in the latest version. [/home/runner/work/docfx/docfx/src/Docfx.App/Docfx.App.csproj]

Error: /usr/share/dotnet/sdk/9.0.100-preview.3.24204.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error PKV006: Target framework net7.0 is no longer supported in the latest version. [/home/runner/work/docfx/docfx/src/Docfx.App/Docfx.App.csproj]

And following message is displayed.

/usr/share/dotnet/sdk/9.0.100-preview.3.24204.13/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.ApiCompat.ValidatePackage.targets(39,5): error : API breaking changes found. If those are intentional, the APICompat suppression file can be updated by rebuilding with '/p:ApiCompatGenerateSuppressionFile=true' [/home/runner/work/docfx/docfx/src/Docfx.App/Docfx.App.csproj]

Above 2-errors are raised because it compare .nupkg compatibility between versions.
And it's detected that .NET 6/7 supports are dropped for nightly CI build.
So suppress errors by adding /p:ApiCompatGenerateSuppressionFile=true parameter to dotnet pack command.


Additionaly. I've modified <NoWarn> property to suppress following warnings displayed on dotnet pack.

  • warning NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of dependency "PdfPig [0.1.9-alpha-20240510-d86c2, )" or update the version field in the nuspec.
  • warning NU5111: The script file 'tools.playwright\package\bin\install_media_pack.ps1' is not recognized by NuGet and hence will not be executed during installation of this package.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.96%. Comparing base (fe673ec) to head (f26ab4e).
Report is 152 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9920      +/-   ##
==========================================
+ Coverage   74.31%   78.96%   +4.64%     
==========================================
  Files         536      538       +2     
  Lines       23189    23315     +126     
  Branches     4056     4047       -9     
==========================================
+ Hits        17234    18411    +1177     
+ Misses       4853     3775    -1078     
- Partials     1102     1129      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yufeih yufeih merged commit 0b26f2c into dotnet:main May 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants