Add OpenWithCreate(...) as a proof of concept. #4162
+151
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-components
davidfowl
reviewed
May 13, 2024
| /// the original exception is thrown. | ||
| /// </para> | ||
| /// </remarks> | ||
| public static void OpenWithCreate(this SqlConnection connection) |
There was a problem hiding this comment.
I mean this isn't public API we would expose right? This should be an ADO.NET thing.
There was a problem hiding this comment.
I said the same in #4160 (comment).
(not sure where the conversation should happen - the issue or the PR)
There was a problem hiding this comment.
Do it in the issue. This was just so we had something concrete to talk about.
And I agree this should be something in ADO.NET
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4160
Microsoft Reviewers: Open in CodeFlow