feat: support Aspire.Hosting.Apache.Pulsar
#4146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
community-contribution
@dotnet-policy-service agree |
maranmaran
changed the title
maranmaran
changed the title
Aspire.Hosting.Apache.Pulsar
radical
removed
the
area-codeflow
timheuer
reviewed
Jun 3, 2024
| public static IResourceBuilder<PulsarResource> AddPulsar( | ||
| this IDistributedApplicationBuilder builder, | ||
| string name, | ||
| int? servicePort = null, |
There was a problem hiding this comment.
we use targetPort more consistently to refer to the underlying container port and port for the broker port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋, first time contributor here
Motivation
To support Apache Pulsar with Aspire Hosting options
Modifications
Aspire.Hosting.Apache.PulsarlibSources
Docs: https://pulsar.apache.org/docs/3.2.x/
.NET Client library: https://github.com/apache/pulsar-dotpulsar
Notes:
Please direct me if I'm missing something 😄.
Regarding Pulsar Manager (UI),
I'd like to wait a tiny bit to bump up the default tag of
PulsarManagerContainerImageTagsso it can support having a default super-user via environment variables which I recently added.The code is in place with this PR and the manager release should be relatively soon.
Questions:
DotPulsarpackage into the playground project so I added my own nuget source.Hope someone could guide me a little on how to get it into the project from current sources.