Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct XML Docs for RabbitMqServerResource.PrimaryEndpoint #4118

Merged
merged 4 commits into from
May 20, 2024

Conversation

afscrome
Copy link
Contributor

@afscrome afscrome commented May 8, 2024

It's a RabbitMQ server, not redis 馃槈.

Microsoft Reviewers: Open in CodeFlow

It's a RabbitMQ server, not redis 馃槈.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label May 8, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 8, 2024
@danmoseley
Copy link
Member

thanks. there's a bunch of copy/pastes of "Gets the primary endpoint for the Redis server." .. can you fix others as needed?

@timheuer
Copy link
Member

timheuer commented May 9, 2024

Also see one for PostgreSQL as a copy/paste typo as well here.

@timheuer timheuer requested a review from eerhardt May 9, 2024 03:49
@afscrome
Copy link
Contributor Author

afscrome commented May 9, 2024

Yea, there are a few - https://github.com/search?q=repo%3Adotnet%2Faspire%20%22Gets%20the%20primary%20endpoint%20for%20the%20Redis%20server%22&type=code .

I can have a look but it may not be until the weekend. If you want to merge this PR in it's current form feel frere and I'll follow up with a second PR. Otherwise I'll append to this one.

@eerhardt eerhardt enabled auto-merge (squash) May 9, 2024 17:05
@danmoseley
Copy link
Member

@afscrome ironically our edits made this large enough we need you to agree to the CLA . Could you do that? You'd probably have needed to do it for the next PR anyway. You only need to do it once.

@afscrome
Copy link
Contributor Author

One of my collogues has already signed the CLA for our company - dotnet/sign#656 (comment) . Do I need to do something to link my account to the company or do I need to agree again.

@danmoseley
Copy link
Member

I believe the bot requires it from every account. But only once each

@danmoseley
Copy link
Member

Note you just have to leave the indicated comment right here in this PR thread

@afscrome
Copy link
Contributor Author

@dotnet-policy-service agree company="Trayport"

@eerhardt eerhardt merged commit cc501f3 into dotnet:main May 20, 2024
8 checks passed
@afscrome afscrome deleted the patch-2 branch May 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants