Add optional serviceName parameter to WithReference methods
#4111
+91
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
community-contribution
paulomorgado
force-pushed
the
service-name
branch
2 times, most recently
from
43d1269
to
c41a7e9
Compare
|
Can't make breaking changes like this now. Add an overload. |
Updated the `WithReference` methods in `ResourceBuilderExtensions.cs` to include an optional `serviceName` parameter for overriding the source resource's name for the service name. The `ApplyEndpoints` and `CreateEndpointReferenceEnvironmentPopulationCallback` methods have been updated to use this new parameter. Updated and added tests in `WithReferenceTests.cs` to cover these changes. The `PublicAPI.Unshipped.txt` file has also been updated to reflect these changes.
paulomorgado
force-pushed
the
service-name
branch
from
c41a7e9
to
c1b7a76
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
WithReferencemethods inResourceBuilderExtensions.csto include an optionalserviceNameparameter for overriding the source resource's name for the service name. TheApplyEndpointsandCreateEndpointReferenceEnvironmentPopulationCallbackmethods have been updated to use this new parameter. Updated and added tests inWithReferenceTests.csto cover these changes. ThePublicAPI.Unshipped.txtfile has also been updated to reflect these changes.Closes #4109
Microsoft Reviewers: Open in CodeFlow