Add AWS Console urls in the dashboard for CloudFormation stacks and resources #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
community-contribution
normj
suggested changes
May 8, 2024
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
needs-author-action
davidfowl
reviewed
May 8, 2024
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationAWSConsoleUrlMapper.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
removed
the
needs-author-action
normj
suggested changes
May 8, 2024
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationProvisioner.cs
Outdated
Show resolved
Hide resolved
dotnet-policy-service
bot
added
the
needs-author-action
dotnet-policy-service
bot
removed
the
needs-author-action
|
@davidfowl an e2e test is failing. Should I push a commit to re-trigger? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationProvisioner.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationProvisioner.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.AWS/CloudFormation/CloudFormationProvisioner.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds URLs in the Aspire Dashboard to the AWS Console for CloudFormation Stacks and a selection of AWS resource types that are commonly used in local development. The resource types are: SQS Queues, SNS Topics, S3 Buckets, Cognito UserPools and DynamoDB Tables/GlobalTables.
It could be that the CloudFormation URL is sufficient but the CloudFormation-panel does not provide URLs for SQS Queues or Global Tables. It's also an extra navigation step. I will let review decide that.
Microsoft Reviewers: Open in CodeFlow