Set assembly metadata with build configuration for AppHost and apply to projects in CLI mode #3961
Conversation
…ne configuration for projects
dotnet-issue-labeler
bot
added
the
area-app-model
src/Aspire.Hosting.AppHost/build/Aspire.Hosting.AppHost.targets
Outdated
Show resolved
Hide resolved
| @@ -88,7 +88,7 @@ public async Task EndpointPortsExecutableNotReplicatedProxiedPortSetNoTargetPort | |||
| Assert.True(dcpExe.TryGetAnnotationAsObjectList<ServiceProducerAnnotation>(CustomResource.ServiceProducerAnnotation, out var spAnnList)); | |||
There was a problem hiding this comment.
Is there any way to test this change?
There was a problem hiding this comment.
@radical discovered this issue by writing an end-to-end test with his workload infrastructure. That is not in yet, but he is aiming on pushing a PR up next week.
There was a problem hiding this comment.
Tests pass with the changes from this PR added to my workload-tests branch.
|
@danegsta is this PR stale? should it be closed? |
|
@joperezr this is likely stale at this point; did we get a different workaround for the release mode problem merged? |
|
I believe so but not 100% sure, I thought @mitchdenny came up with a different fix? I can test real quick |
|
Just tested this and it is in fact not yet fixed. Looks like this is one thing we'll want to take for 8.1. There was some conversation in chat around using special attributes, assuming all of the feedback is already incorporated with this PR? |
|
Yeah, it's been updated to honor the built-in |
|
I'll merge main into the PR branch to kick off a fresh build, just to make sure nothing has drifted far enough to cause issues since the last build. |
Microsoft Reviewers: Open in CodeFlow