Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential github action smells #32420

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

ceddy4395
Copy link
Contributor

Hey! 馃檪
I want to contribute the following changes to your workflow:

  • Avoid executing scheduled workflows on forks
  • Stop running workflows when there is a newer commit in branch

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

- Avoid executing  scheduled workflows on forks
- Stop running workflows when there is a newer commit in branch
@ceddy4395
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I had one suggestion, and then I'd say :shipit:

.github/workflows/whats-new.yml Outdated Show resolved Hide resolved
@Rick-Anderson Rick-Anderson merged commit 37e318d into dotnet:main Apr 29, 2024
3 checks passed
@Rick-Anderson
Copy link
Contributor

@ceddy4395 thanks for the contribution.
@BillWagner thanks for the quick review and suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants