[typescript-resolvers] Fix interfaces not handling nested correctly #9962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where self-referencing and nested interfaces are not using resolver types correctly.
Interface is an abstract type like union. So, we need to reference the
ResolversInterfaceTypes
whenever there's a object type with a field with type interface or an array of interfaces.Otherwise, the wrapping object type would just refer to the base generated type, causing mappers for the interface to be ignored.
Related eddeee888/graphql-code-generator-plugins#266
Note that this bug has been here for awhile. I can observe that in this PR to rebase tests. So at least it's been around before
ResolversInterfaceTypes
implementationExample
Given this schema:
And this mapper:
Before
After
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration