Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 28251 replacing api calls #28544

Merged
merged 54 commits into from
May 20, 2024
Merged

Issue 28251 replacing api calls #28544

merged 54 commits into from
May 20, 2024

Conversation

fabrizzio-dotCMS
Copy link
Contributor

@fabrizzio-dotCMS fabrizzio-dotCMS commented May 13, 2024 •
edited

Proposed Changes

  • A Feature Flag in the form of a method called isLocalizationEnhancementsEnabled has been added to activate/deactivate the functionality.
  • The Feature flag is for now on. If we want to release we need to set it to off.
  • Added the capability of accessing the language variable in the cache using only the key and the lang ID
  • Fixed a bug in the queries introduced when changed to show both live and working content. The bug was making all archived pieces of content appear in the results.
  • Fixes on Integration Tests
  • Fixes on postman test. That was caused by a dupe key introduced during the postman run. The unique key constraint can be lifted, so we must be prepared for such a situation.
  • New API Calls added next to the old one. The new ones are executed instead of the old APIs only if the feature flag is on.

fabrizzio-dotCMS and others added 30 commits May 3, 2024 13:15
@fabrizzio-dotCMS
#27979
0c88bd7
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
e5998e7
@fabrizzio-dotCMS
#27979
832075c
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
d264292
@fabrizzio-dotCMS
#27979 cache invalidation
4eec0b2
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
34a42b8
@fabrizzio-dotCMS
#27979 api calls replaced
9b13cc3
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
c490b99
@fabrizzio-dotCMS
#27979 reverting changes to keep smaller pr
e1d2497
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
bf33c2d
@fabrizzio-dotCMS
#27979 adding postman for the new endpoint
9395a56
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' of https://github…
38bca4e 
….com/dotCMS/core into issue-27979-lang-vars-backend-take-2
@fabrizzio-dotCMS
#27979 adding more test
52a36ba
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
96daa8c
@fabrizzio-dotCMS
#27979 optimize imports
db1e5d9
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' of https://github…
08629c3 
….com/dotCMS/core into issue-27979-lang-vars-backend-take-2
@fabrizzio-dotCMS
#27979
547d2b1
@fabrizzio-dotCMS
#27979 fix postman
a336d8d
@fabrizzio-dotCMS
#28251
be1c347
@fabrizzio-dotCMS
Merge branch 'master' into issue-27979-lang-vars-backend-take-2
6394ea4
@fabrizzio-dotCMS
#27979
4be1309
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' into issue-28251-…
c88af63 
…api-calls-take-2
@fabrizzio-dotCMS
#27979 doc
58675f4
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' into issue-28251-…
b6f4d9f 
…api-calls-take-2
@fabrizzio-dotCMS
#27979
69aa0e4
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' into issue-28251-…
845c4cc 
…api-calls-take-2
@fabrizzio-dotCMS
#28251
7546f83
@fabrizzio-dotCMS
#27979
645a711
@fabrizzio-dotCMS
Merge branch 'issue-27979-lang-vars-backend-take-2' into issue-28251-…
afa8450 
…api-calls-take-2
@fabrizzio-dotCMS
#27979 feedback
f81cc3c
@fabrizzio-dotCMS fabrizzio-dotCMS changed the base branch from master to issue-27979-lang-vars-backend-take-2 May 13, 2024 20:29
Base automatically changed from issue-27979-lang-vars-backend-take-2 to master May 13, 2024 21:42
@fabrizzio-dotCMS fabrizzio-dotCMS mentioned this pull request May 16, 2024
Closed
@fabrizzio-dotCMS fabrizzio-dotCMS marked this pull request as ready for review May 17, 2024 17:10
@nollymar nollymar linked an issue May 17, 2024 that may be closed by this pull request
Replace all api calls that retrieve LanguageKey by the a new APIs that return LanguageVariable (Content) #28251
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
18 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@fabrizzio-dotCMS fabrizzio-dotCMS added this pull request to the merge queue May 20, 2024
Merged via the queue into master with commit 3a812ff May 20, 2024
26 checks passed
@fabrizzio-dotCMS fabrizzio-dotCMS deleted the issue-28251-api-calls-take-2 branch May 20, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsolistorres dsolistorres dsolistorres approved these changes

@nollymar nollymar nollymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
dotCMS - Product Planning
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace all api calls that retrieve LanguageKey by the a new APIs that return LanguageVariable (Content)
3 participants
@fabrizzio-dotCMS @dsolistorres @nollymar