Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization in DotExperiments Class #28528

Merged
merged 4 commits into from
May 15, 2024
Merged

Optimization in DotExperiments Class #28528

merged 4 commits into from
May 15, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented May 10, 2024

Proposed Changes

  • No send event (Track PageView) if we don't have assigned experiments to the user
  • Fetch from isUserAssigned the experiments if the user does not have experiments assigned.
  • Improve the logs for track the changes.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

@oidacra oidacra linked an issue May 10, 2024 that may be closed by this pull request
Optimization and Bug Fixes for @dotcms/experiments Handling Procedures #28283
Closed
@oidacra oidacra marked this pull request as draft May 10, 2024 19:34
@oidacra oidacra marked this pull request as ready for review May 15, 2024 14:35
@oidacra oidacra added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@oidacra oidacra enabled auto-merge May 15, 2024 17:20
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@oidacra oidacra added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit 94e7f54 May 15, 2024
15 checks passed
@oidacra oidacra deleted the issue-28283 branch May 15, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoreras hmoreras hmoreras approved these changes

@rjvelazco rjvelazco rjvelazco approved these changes

@fmontes fmontes Awaiting requested review from fmontes

@zJaaal zJaaal Awaiting requested review from zJaaal

@KevinDavilaDotCMS KevinDavilaDotCMS Awaiting requested review from KevinDavilaDotCMS

Assignees
No one assigned
Labels
None yet
Projects
dotCMS - Product Planning
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optimization and Bug Fixes for @dotcms/experiments Handling Procedures
3 participants
@oidacra @hmoreras @rjvelazco