Swapping display of Height/Width in UVE device selector #28520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dimensions should display as `{Width} x {Height}` instead of `{Height} x {Width}`; this just swaps them.
fmontes
approved these changes
May 9, 2024
|
The automated tests do seem to hate me. Fingers crossed! |
zJaaal
approved these changes
May 10, 2024
|
Now that I understand the problem, I'm gonna shut this down and re-do it from a core branch to save everyone a headache. |
auto-merge was automatically disabled
May 17, 2024 17:52
Pull request was closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 21, 2024
Dimensions should display as `{Width} x {Height}` instead of `{Height} x
{Width}` in the dropdown; this just swaps them.
Solves #28517.
Redo of #28520, but this time I'm not
working off a fork, so that should simplify things!
Signed-off-by: Jamie Mauro <[email protected]>
spbolton
pushed a commit
that referenced
this pull request
Jun 3, 2024
Dimensions should display as `{Width} x {Height}` instead of `{Height} x
{Width}` in the dropdown; this just swaps them.
Solves #28517.
Redo of #28520, but this time I'm not
working off a fork, so that should simplify things!
Signed-off-by: Jamie Mauro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dimensions should display as
{Width} x {Height}instead of{Height} x {Width}in the dropdown; this just swaps them.