Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config path to comply with XDG Base Directory spec #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update config path to comply with XDG Base Directory spec #90

wants to merge 1 commit into from

Conversation

SanketDG
Copy link
Contributor

@SanketDG
Copy link
Contributor Author

I am not sure what else files are used, some help would be appreciated!

@codecov-io
Copy link

codecov-io commented Oct 31, 2016

Current coverage is 95.18% (diff: 100%)

Merging #90 into master will not change coverage

@@             master        #90   diff @@
==========================================
  Files            34         34          
  Lines          2076       2076          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1976       1976          
  Misses          100        100          
  Partials          0          0          

Powered by Codecov. Last update eebb2cf...b9994bd

@donnemartin
Copy link
Owner

Hi @SanketDG, you're on a roll, thanks for the second PR! I'll try to review it this week.

@donnemartin
Copy link
Owner

Hi, took a closer look...

From https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html:

If $XDG_CONFIG_HOME is either not set or empty, a default equal to $HOME/.config should be used.

On my system, I don't have $XDG_CONFIG_HOME configured. It seems like we'd have to add additional logic to set the path to $HOME/.config?

Also, curious how this affects Windows.

@Jimimaku
Copy link

Jimimaku commented Nov 21, 2022

Die aktuelle Abdeckungbeträgt 95,18% (diff: 100%)

Das Zusammenführen von #90inMasterändert die Abdeckung nicht

@@             master        #90   diff @@
==========================================
  Files            34         34          
  Lines          2076       2076          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1976       1976          
  Misses          100        100          
  Partials          0          0          

Unterstützt vonCodecov. Letzte Aktualisierungeebb2cf... B9994BD

@Jimimaku
Copy link

Jimimaku commented Nov 22, 2022

Hallo, habe genauer hingeschaut...

Vonhttps://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html:

Wenn $XDG_CONFIG_HOME entweder nicht festgelegt oder leer ist, sollte der Standardwert $HOME/.config verwendet werden.

Auf meinem System habe ich $XDG_CONFIG_HOME nicht konfiguriert. Es scheint, als müssten wir zusätzliche Logik hinzufügen, um den Pfad festzulegen?$HOME/.config

Auch neugierig, wie sich dies auf Windows auswirkt.

@Jimimaku
Copy link

Jimimaku commented Nov 22, 2022

Hallo@SanketDG, du bist auf einer Rolle, danke für die zweite PR! Ich werde versuchen, es diese Woche zu überprüfen.

@Jimimaku
Copy link

Jimimaku commented Nov 22, 2022

Ich bin mir nicht sicher, welche anderen Dateien verwendet werden, etwas Hilfe wäre willkommen!

@Jimimaku
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants