Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List dependencies in setup.py instead of embedding #82

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simon04
Copy link

@simon04 simon04 commented Oct 20, 2016

This helps packaging this tool for Linux distributions.

@codecov-io
Copy link

Current coverage is 95.18% (diff: 100%)

Merging #82 into master will not change coverage

@@             master        #82   diff @@
==========================================
  Files            34         34          
  Lines          2076       2076          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1976       1976          
  Misses          100        100          
  Partials          0          0          

Powered by Codecov. Last update 9aaccab...d92bb73

@donnemartin
Copy link
Owner

Hi @simon04, thanks for the PR!

This is something I'd like to move towards. There are some customizations to each dependency in the lib folder that would need to make it back to the main repo for this to be completed.

@fzerorubigd
Copy link

The problem is, some of this dependencies are out dated. for example my problem is with uritemplate.py that should be <1.0.0,>=0.2.0 but the current version is 3.0.0
could you please at least update this dependencies?

@donnemartin
Copy link
Owner

@fzerorubigd I'll see about updating, thanks for the heads up.

@donnemartin
Copy link
Owner

@fzerorubigd I updated the dependency for uritemplate.py, let's use #86 for additional discussions.

@donnemartin
Copy link
Owner

@timofonic sorry been really tied up with work, not sure when this will reach the top of my queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants