Big refactor with split of code by functional area #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dashboard.py (browser endpoints) - wg.py (Wireguard related functions) - db.py (Database related functions) - rest_routes.py (REST call enpoints) Also simplified and reused code wherever possible.
theonlynexus
changed the title
theonlynexus
changed the title
|
I have forked the project, and I am continuing development at https://github.com/theonlynexus/WGDashboard_2 If and when you have time to pick up development again, I am more than willing to merge the two code-bases again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: some of the DB fields have been renamed, thus this is a breaking PR
In this PR, the application has been split into:
I also tried to keep it DRY and simplify code wherever possible. 99% of the changes are in the Python files, a few small changes have been done to templates and Javascript files.
In theory performance should also be improved, as the code was simplified. For example, the configuration is read only once, before each request, instead of being reloaded in a number of different methods.