replace reusePort
by failOnExistingPort
, simpler state (single bool), no TOCTOU for numThreads=1
#53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should be followed by dom96/jester#281 in jester
alternative to #50 and #52 that hits all the targets:
jester.reusePort
ashttpbeast.failOnExistingPort
=not reusePort
failOnExistingPort
inside httpbeast, it's consistentThe only downside is that this is a breaking change from the previous commit for client code that would've used thew new reusePort flag, but it was introduced very recently (10 days ago), and wasn't the commit I had signed up for, refs #47 (comment)
so I've bumped the version to 0.5.0
(an alternative to this 10 day-window breaking change would be possible by adding a different
initSettings2
and deprecatinginitSettings
, or simply defineinitSettings
by interpreting the reusePort argument asnot failOnExistingPort
; but this software is pre-1.0 and it's only a 10-day window so IMO is acceptable)