Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decimal refactor and more improvements #2328

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

decimal refactor and more improvements #2328

wants to merge 31 commits into from

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Feb 15, 2024 •
edited

TODO: datetimes are now broken...

This PR aims to:

  • simplify the logic surrounding how we handle type conversions in Arithmetic nodes
    • sql.Type.Convert() should be able to convert to/from time types...
  • improve the cleanliness and efficiency of outermost arithmetic op
  • fix datetime (specifically with precision handling)

James Cor and others added 19 commits February 9, 2024 15:27
fix decimal return type
5b7216c
Merge branch 'main' into james/in
96e6723
@jycor
[ga-format-pr] Run ./format_repo.sh to fix formatting
367930e
guard max precision
6e4b7a4
merge with main
08bd71f
prevent scale > precision and wire fix
562b30e
various type fixes
6b9dcf7
rewriting tests for add, sub, and mult
e7f396a
rewriting div tests
847f4f0
more tests
8bbaa44
@jycor
[ga-format-pr] Run ./format_repo.sh to fix formatting
b0a5aa5
implement internal decimal scale
a98c9cb
@jycor
[ga-format-pr] Run ./format_repo.sh to fix formatting
c45c076
reverting changes to memory_engine_test
da9a769
clean up
a595026
Merge branch 'james/in' of https://github.com/dolthub/go-mysql-server …
edd1b04 
…into james/in
fix test
5bc7edb
removing unused code
65c3451
simplifies arithmetic conversion logic, but breaks datetime stuff
a8ecd28
@jycor jycor changed the base branch from main to james/in February 15, 2024 20:06
@jycor jycor marked this pull request as draft February 15, 2024 20:06
Base automatically changed from james/in to main February 16, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jycor