DSPHLE/Zelda: Add two missing filters #12773
Open
+108
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The biquad filter is used in all Pikmin games for cursor sound effects in the main menu, although the difference is subtle. The low-pass filter is used at least by Pikmin 2 Wii during the spaceship crash in the intro and fixes the missing "puff" sound effects whenever there is black smoke coming out of the engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biquad filter is used in all Pikmin games for cursor sound effects in the main menu, although the difference is subtle.
EDIT: It's also used for some instruments in sequenced songs.
The low-pass filter is used at least by Pikmin 2 Wii during the spaceship crash in the intro and fixes the missing "puff" sound effects whenever there is black smoke coming out of the engine.
Before:
https://github.com/dolphin-emu/dolphin/assets/123798/795fc7d8-a653-48d7-a0c0-d29d92467d98
After:
https://github.com/dolphin-emu/dolphin/assets/123798/b587737c-2e8a-41e0-8742-75e379f64981