ScmRevGen: Generate Info.plist files containing the current version #12728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OatmealDome
force-pushed
the
mac-version-numbers-2
branch
from
c69060b
to
6e78fd3
Compare
BhaaLseN
reviewed
Apr 21, 2024
OatmealDome
force-pushed
the
mac-version-numbers-2
branch
from
6e78fd3
to
5aa0941
Compare
OatmealDome
force-pushed
the
mac-version-numbers-2
branch
from
5aa0941
to
c154134
Compare
|
The CMake code itself looks sane, but I have never touched macOS in my life so I cannot tell you whether this is actually correct for the platform. |
|
If the CMake makes sense, that's good enough for me. (I tested the build artifacts and they seem to work fine.) I'll wait like a day or so and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS, our app bundle currently has no version number set. This was broken in a previous
ScmRevGen-related commit, as the necessary version variables no longer exist outside of theScmRevGencmake instance.So, let's have ScmRevGen generate the
Info.plistfor us.