Lock deploys immediately upon starting a deploy process #6223
+66
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
force-pushed
the
lock-all-deploys
branch
from
b350a5e
to
2fd59f2
Compare
Merged
josegonzalez
force-pushed
the
lock-all-deploys
branch
from
2fd59f2
to
60f5581
Compare
Previously, some attempts to trigger a deploy would lock much later than desired, making it possible to trigger race conditions during deploys. We now lock as soon as possible for all cases where receive-app might be called in the request chain.
josegonzalez
force-pushed
the
lock-all-deploys
branch
from
60f5581
to
c623f58
Compare
Since the logic is now wrapped in other functions, we need to surface the exit code appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some attempts to trigger a deploy would lock much later than desired, making it possible to trigger race conditions during deploys. We now lock as soon as possible for all cases where receive-app might be called in the request chain.