Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FreeBSD support #3956

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add FreeBSD support #3956

wants to merge 1 commit into from

Conversation

er2off
Copy link

@er2off er2off commented Apr 13, 2024

This pull request adds initial FreeBSD operating system support.

To build: env CC=cc CXX=c++ ./package_native.sh <other args here> --64-only (for 64-bit system)
(gcc13 is currently not working)

meson.build Outdated Show resolved Hide resolved
@flibitijibibo
Copy link
Contributor

Just did a fresh rebase of #3834, does rebasing this on top of those changes help make the meson changes unnecessary?

@er2off
Copy link
Author

er2off commented May 12, 2024

does rebasing this on top of those changes help make the meson changes unnecessary?

@flibitijibibo yes, it works perfect. Also gcc build is workable if add limits.h include to src/util/util_env.cpp (why it worked with clang without this include?)

@flibitijibibo
Copy link
Contributor

The relevant meson changes were merged, so this should be able to rebase without the meson.build changes and work as intended!

Copy link
Collaborator

@Joshua-Ashton Joshua-Ashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge after nit addressed

src/util/util_env.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants