Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: background tasks #1160

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: background tasks #1160

wants to merge 6 commits into from

Conversation

Mythie
Copy link
Collaborator

@Mythie Mythie commented May 15, 2024

Description

Currently a work in progress but this adds background tasks to Documenso for handling tasks that take a little longer and aren't part of the overall critical path.

Related Issue

N/A

Changes Made

Added a pluggable jobs provider supporting both a local provider and a Trigger.dev provider.

Testing Performed

  • Verified job level retries work
  • Verified task level retries work without incrementing job retries

image
image

This will still have a lot of rough edges but is a perfect MVP for local durable compute which may accept more providers later on

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
prd-app 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 22, 2024 0:09am
stg-app ❌ Failed (Inspect) May 22, 2024 0:09am
stg-docs ❌ Failed (Inspect) May 22, 2024 0:09am
stg-marketing ❌ Failed (Inspect) May 22, 2024 0:09am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
prd-marketing ⬜️ Ignored (Inspect) May 22, 2024 0:09am

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Important

Review Skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added apps: web Issues related to the webapp version bump 👀 apps: marketing Issues related to website or marketing app pkg: ee changes labels May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Thank you for following the naming conventions for pull request titles! 💚🚀

packages/lib/jobs/client/local.ts Dismissed Show dismissed Hide dismissed
packages/lib/jobs/client/local.ts Dismissed Show dismissed Hide dismissed
packages/lib/jobs/client/local.ts Dismissed Show dismissed Hide dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: marketing Issues related to website or marketing app apps: web Issues related to the webapp 🚨 migrations 🚨 pkg: ee changes version bump 👀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant