Add precision to MSSQL datetime2 #6393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yovach
changed the title
Yovach
force-pushed
the
feat/add-precision-to-mssql-datetime2
branch
from
d6af843
to
279aab8
Compare
|
The 3.8.x branch is closed for features. Please target 4.1.x. Also, this topic has been attempted before and is a little more complex than your implementation. Maybe you can have a look at #5961 at take over where the previous author has left off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We sometimes don't need to be accurate to the microsecond on certain tables. (i.e. tables with 'enumType'). This MR saves space on very large data processing operations.
I don't know if the precision check is relevant, let me know!