Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize ORM 3 Support #2814

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Finalize ORM 3 Support #2814

merged 9 commits into from
Jun 10, 2024

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jun 9, 2024

This should be the last bit that's needed to finish out #2708.

  • Needs Run tests without doctrine/annotations installed #2781 to merge first to be able to build on the CI architecture (it's blowing up pretty badly right now because of the presence of doctrine/annotations and the auto-detection code in our Gedmo\Mapping\MappedEventSubscriber class) Handled in the testing bootstrap instead
  • I haven't even looked at the PHPStan report yet, that can be dealt with once we have consistent green PHPUnit builds Baseline refreshed

Copy link

codecov bot commented Jun 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.79%. Comparing base (0632ab1) to head (067365a).
Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2814      +/-   ##
==========================================
+ Coverage   78.75%   78.79%   +0.04%     
==========================================
  Files         163      167       +4     
  Lines        8593     8629      +36     
==========================================
+ Hits         6767     6799      +32     
- Misses       1826     1830       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbabker mbabker changed the title [WIP] Finalize ORM 3 Support Finalize ORM 3 Support Jun 9, 2024
@mbabker mbabker marked this pull request as ready for review June 9, 2024 19:39
@franmomu franmomu merged commit f562f34 into doctrine-extensions:main Jun 10, 2024
22 checks passed
@franmomu
Copy link
Collaborator

Thank you @mbabker for all the work you're doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants