Stop passing parameters by reference in mapping drivers #2609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansys
force-pushed
the
mapping_references
branch
2 times, most recently
from
5033463
to
a4733e3
Compare
franmomu
reviewed
May 10, 2023
src/Uploadable/Mapping/Validator.php
Outdated
| */ | ||
| #[\ReturnTypeWillChange] |
There was a problem hiding this comment.
Same concern here about the use of the ReturnTypeWillChange attribute.
phansys
force-pushed
the
mapping_references
branch
2 times, most recently
from
e9e7100
to
3077db3
Compare
franmomu
approved these changes
Aug 19, 2023
phansys
force-pushed
the
mapping_references
branch
from
3077db3
to
eac0d7d
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
==========================================
+ Coverage 79.60% 79.64% +0.03%
==========================================
Files 161 161
Lines 8415 8468 +53
==========================================
+ Hits 6699 6744 +45
- Misses 1716 1724 +8
☔ View full report in Codecov by Sentry. |
Nice catch! 😶🌫️ Thank you! |
phansys
force-pushed
the
mapping_references
branch
from
eac0d7d
to
f3f4ff5
Compare
phansys
force-pushed
the
mapping_references
branch
2 times, most recently
from
7b3a0a1
to
f4a6945
Compare
phansys
force-pushed
the
mapping_references
branch
from
f4a6945
to
3772a39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2605, as this is the first step to gain governance around the manipulation performed on the received mapping configuration.