fix(ci): run test action for pull requests #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Koooooo-7
changed the title
sy-records
reviewed
May 29, 2024
Comment on lines
+3
to
9
| on: | ||
| push: | ||
| branches: [master, main, develop] | ||
| pull_request: | ||
| branches: [master, main, develop] | ||
| workflow_dispatch: | ||
|
|
There was a problem hiding this comment.
The ci for test will now run as well, so why add this?
There was a problem hiding this comment.
The push only for us who have access to the repo. It does not trigger by PRs for contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
test.ymlworkflow, correct it to be trigger on pull request.Related issue, if any:
What kind of change does this PR introduce?
Bugfix
For any code change,
Does this PR introduce a breaking change?
Yes
No
No
Tested in the following browsers: