Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update lint configuration (ESLint 9, Prettier 3) #2438

Merged
merged 9 commits into from
May 28, 2024
Merged

chore: Update lint configuration (ESLint 9, Prettier 3) #2438

merged 9 commits into from
May 28, 2024

Conversation

jhildenbiddle
Copy link
Member

@jhildenbiddle jhildenbiddle commented May 23, 2024 •
edited

Summary

No functional changes. This PR contains updates to our lint-related dev dependencies and a number of file resulting from the updated lint tools and configuration.

  • Update ESLint from v8 to v9
  • Update Prettier from v2 to v3
  • Migrate ESLint configuration to new flat configuration format
  • Remove deprecated ESLint rules
  • Remove ESLint rules from config that match default values
  • Remove eslint-plugin-import (no ESLint v9 support)
  • Fix lint issues throughout repo

Related issue, if any:

N/A

What kind of change does this PR introduce?

Build-related changes

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

@vercel Vercel
Copy link

vercel bot commented May 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 6:19am

Koooooo-7
Koooooo-7 previously approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

trusktr
trusktr reviewed May 24, 2024
View reviewed changes
playwright.config.js Outdated Show resolved Hide resolved
trusktr
trusktr reviewed May 24, 2024
View reviewed changes
test/helpers/wait-for.js Outdated Show resolved Hide resolved
Koooooo-7
Koooooo-7 previously approved these changes May 25, 2024
View reviewed changes
Koooooo-7
Koooooo-7 approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're really on the ball ! 🚀

@jhildenbiddle
Copy link
Member Author

@Koooooo-7 --

Just trying to keep things moving! Thanks for the quick review and helpful input. Much appreciated. :)

@jhildenbiddle
Copy link
Member Author

Thanks @trusktr for the quick follow-up after last week's review. Much appreciated! 🙏

@jhildenbiddle jhildenbiddle merged commit f5412dc into develop May 28, 2024
9 checks passed
@jhildenbiddle jhildenbiddle deleted the lint-update branch May 28, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trusktr trusktr trusktr approved these changes

@paulhibbitts paulhibbitts paulhibbitts approved these changes

@Koooooo-7 Koooooo-7 Koooooo-7 approved these changes

@sy-records sy-records Awaiting requested review from sy-records

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jhildenbiddle @trusktr @paulhibbitts @Koooooo-7