Ask to confirm the export when the tarball already exists in the directory #3 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benja-M-1
reviewed
May 17, 2024
Comment on lines
+46
to
+53
| fmt.Println("A file with the same name already exists in the target directory.") | ||
| fmt.Println("Do you want to:") | ||
| fmt.Println("1. Overwrite the existing file (O)") | ||
| fmt.Println("2. Keep both files (K)") | ||
| fmt.Println("3. Cancel the export (C)") | ||
|
|
||
| var userInput string | ||
| fmt.Scanln(&userInput) |
There was a problem hiding this comment.
question: I am not sure to understand how this can work. How the user could do anything at this point? Since this is in a handler it is not interactive, the handler treats an HTTP request and return an HTTP response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @benja-M-1
I hope this message finds you well. I wanted to reach out and let you know that I've recently made some contributions to Docker/Volumes-backup on GitHub. I've put in my best effort to improve volume, including
Confirmation for Overwriting:
- Overwrite the existing file (O)
- Keep both files by renaming the new file (K)
- Cancel the export (C)
Github Project Repo -- https://github.com/docker/volumes-backup-extension.git
Some piece of code added in --
https://github.com/docker/volumes-backup-extension/blob/main/vm/internal/handler/export.go
line -- 43-67
I would greatly appreciate it if you could take a moment to review my changes and provide any feedback or suggestions for improvement. Your expertise and guidance would be invaluable to me, and I'm eager to learn and contribute further to the project.
Thank you for considering my contributions. I look forward to hearing from you soon.
Best regards,
Vinod