Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpm: add rockylinux and almalinux #138

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

rpm: add rockylinux and almalinux #138

wants to merge 2 commits into from
+100 −4

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Aug 5, 2023 •
edited
Loading

@crazy-max crazy-max force-pushed the rockylinux branch 6 times, most recently from bcfb685 to e4c5162 Compare August 5, 2023 07:44
AkihiroSuda
AkihiroSuda reviewed Aug 5, 2023
View reviewed changes
pkg/docker-engine/scripts/pkg-rpm-build.sh Outdated
@@ -68,7 +68,7 @@ if [ -n "$(xx-info variant)" ]; then
fi

case "$PKG_RELEASE" in
centos7|centos8|centos9|oraclelinux*)
centos7|centos8|centos9|oraclelinux*|rockylinux8)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about rockylinux9 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum right, excluding btrfs on rocky 8 or 9 doesn't look necessary actually. Probably since we don't install btrfs deps anymore since #79. I will revisit this for centos and oraclelinux, this might have been an oversight.

@AkihiroSuda AkihiroSuda mentioned this pull request Aug 3, 2023
Open
3 tasks
@crazy-max crazy-max force-pushed the rockylinux branch 2 times, most recently from 66d109d to d95cbe2 Compare August 5, 2023 09:23
@crazy-max crazy-max changed the title rpm: add rockylinux 8 and 9 rpm: add rockylinux and almalinux Aug 5, 2023
@crazy-max
Copy link
Member Author

Added alma linux as well

@crazy-max
Copy link
Member Author

crazy-max commented Oct 21, 2023 •
edited
Loading

@thaJeztah @neersighted I see rocky and alma pkgs are being built for containerd now: docker/containerd-packaging@967611b. Are we good merging this one?

@crazy-max crazy-max force-pushed the rockylinux branch 2 times, most recently from 3a2e57a to 453c591 Compare October 28, 2023 03:24
@AkihiroSuda
Copy link

What's the current status?

EOL of CentOS Stream 8 is approaching (2024-05-31), so it would be nice to merge this soon

@crazy-max
Copy link
Member Author

What's the current status?

EOL of CentOS Stream 8 is approaching (2024-05-31), so it would be nice to merge this soon

We can merge this one for testing but release packaging happening on download.docker.com is still linked to https://github.com/docker/docker-ce-packaging

@crazy-max crazy-max marked this pull request as ready for review February 8, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dist/almalinux dist/rockylinux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@crazy-max @AkihiroSuda