Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit on the fence here; the
Int()
function does not have an error-return in its signature, so even if the error would not be ignored, there's nowhere to send it to (other than logging or a panic);go-connections/nat/nat.go
Lines 80 to 87 in fa09c95
The
Range()
function does have an error return, so the error can be handled (or ignored) by consumers.Was there an issue you ran into, other than error-handling being inconsistent?
(for transparency; the code in this repository is quite old, and not all parts are very well designed; we're still evaluating the future of this repository, and possibly breaking it up / moving code elsewhere)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, inconsistent error handling was the only issue.
Okay, if there is a possibility that the code is being moved or broken up, this PR won't contribute much. I guess we can just close it.