Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh admin and security FAQ pages #20084

Merged
merged 6 commits into from
May 29, 2024

Conversation

stephaurelio
Copy link
Contributor

Description

Freshness PR editing and refining admin and security FAQs, updating descriptions, and making sure titles are consistent.

Related issues or tickets

Closes JIRA: https://docker.atlassian.net/browse/ENGDOCS-2100

@github-actions github-actions bot added area/security area/subscription Relates to Docker pricing and subscription area/admin Relates to Docker Admin hugo Updates related to hugo labels May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit bd26c0c
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/665652caa089e10009678145
😎 Deploy Preview https://deploy-preview-20084--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the area/release Relates to CI or deployment label May 23, 2024
@stephaurelio
Copy link
Contributor Author

Vale really hates the FAQ format for headings 🙏

@stephaurelio stephaurelio marked this pull request as ready for review May 23, 2024 22:05
@stephaurelio stephaurelio requested review from a team and removed request for aevesdocker May 23, 2024 22:05

### Is it possible to connect Docker Hub directly with a Microsoft Entra (formerly Azure AD) group?

Yes, Entra ID (formerly Azure AD) is supported with SSO for Docker Business, both through a direct integration and through SAML.

### My SSO connection with Entra ID (formerly Azure AD) isn't working and I receive an error that the application is misconfigured. How can I troubleshoot this?
### My SSO connection with Entra ID isn't working and I receive an error that the application is mis-configured. How can I troubleshoot this?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just me, but I actually prefer "misconfigure" over "mis-configure"

Suggested change
### My SSO connection with Entra ID isn't working and I receive an error that the application is mis-configured. How can I troubleshoot this?
### My SSO connection with Entra ID isn't working and I receive an error that the application is misconfigured. How can I troubleshoot this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do too but the spellchecker yelled at me 😅 I think I'll change it back

dvdksn
dvdksn previously approved these changes May 24, 2024
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a subjective nit but feel free to ignore

@dvdksn
Copy link
Contributor

dvdksn commented May 29, 2024

The vale error is unrelated and due to a limitation with github annotations https://github.com/docker/docs/actions/runs/9276848764/job/25524824638?pr=20084#step:3:11268

@stephaurelio stephaurelio merged commit da58f6c into docker:main May 29, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/admin Relates to Docker Admin area/release Relates to CI or deployment area/security area/subscription Relates to Docker pricing and subscription hugo Updates related to hugo status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants