Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGDOCS-2080b #20080

Merged
merged 3 commits into from
May 23, 2024
Merged

ENGDOCS-2080b #20080

merged 3 commits into from
May 23, 2024

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented May 22, 2024

Description

removes links from includes sections

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 324436f
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/664de0f2a78541000809955b
😎 Deploy Preview https://deploy-preview-20080--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested review from jhrotko and a team May 22, 2024 12:04
@aevesdocker aevesdocker requested a review from dvdksn May 22, 2024 12:15
{{< include "compose/services-healthcheck.md" >}}
{{< include "compose/services-healthcheck.md" >}}

For more information on `HEALTHCHECK`, see the [Dockerfile reference](../../reference/dockerfile.md#healthcheck).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add in this file references for the for top-level links for networks, volumes and secrets

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I need to think of a nice way to tie it in to the rest of the content. So doing that in a follow up PR, so this doesn't block you.

@aevesdocker aevesdocker requested a review from a team May 22, 2024 13:46
@aevesdocker aevesdocker merged commit 5af3712 into docker:main May 23, 2024
11 checks passed
@aevesdocker aevesdocker mentioned this pull request May 23, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants