WIP: Added Office plugin for Asciidoctorj #557

mattes3 · 2021-03-17T08:41:28Z

PLEASE DO NOT MERGE THIS PULL REQUEST, YET!

I need help because the one-liner that I added breaks the existing tests. Could you please have a look why this happens?

Thank you,
Matthias

rdmueller · 2021-03-22T22:04:34Z

I tried to read and undestand the logs, but something strange happened here. So I just triggered the build again to see if it maybe was just a hickup

rdmueller · 2021-03-22T22:10:17Z

no hickup :-(

rdmueller · 2021-03-22T22:31:59Z

so, it seems that these tests really fail.
I ran ./gradlew test locally and checked the report.

This seems to be the root cause:

Caused by: groovy.lang.MissingMethodException: No signature of method: org.asciidoctor.jruby.internal.JRubyAsciidoctor.renderFile() is applicable for argument types: (File, LinkedHashMap) values: [/home/rdmueller/projects/clean/tmp/docToolchain/src/test/docs/simplePresentation.adoc, ...]
Possible solutions: convertFile(java.io.File, java.util.Map), convertFile(java.io.File, org.asciidoctor.Options), convertFile(java.io.File, org.asciidoctor.OptionsBuilder)
	at org.asciidoctor.gradle.AsciidoctorProxyImpl.renderFile(AsciidoctorProxyImpl.groovy:26)
	at org.asciidoctor.gradle.AsciidoctorProxy$renderFile.call(Unknown Source)
	at org.asciidoctor.gradle.AsciidoctorTask.processSingleFile(AsciidoctorTask.groovy:676)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.asciidoctor.gradle.AsciidoctorTask$_processDocumentsAndResources_closure7.doCall(AsciidoctorTask.groovy:656)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.asciidoctor.gradle.AsciidoctorTask.processDocumentsAndResources(AsciidoctorTask.groovy:651)
	... 108 more

rdmueller · 2021-03-22T22:39:54Z

so, it seems that the plugin brings its own dependencie to asciidoctorj along.

Can you please try to specify the dependency as follows:

    asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') {
        exclude group: 'org.asciidoctor', module: 'asciidoctorj'
    }

this turns the tests at least to green, but I don't know if the plugin then still works.

mattes3 · 2021-03-23T06:15:55Z

Thank you, Ralf, for analyzing this. I'll have a look at what happens now.

rdmueller · 2021-03-23T15:34:45Z

Could you already test if the extension still works?

mattes3 · 2021-03-23T16:03:10Z

Not yet, I was in a training the whole day. However, I made it compile and test, then I committed it.

How can I easily test it on a new document that contains the slide::/path/to/powerpointFile.pptx[slideNumber=1] syntax, without needing to build a docker image for doctoolchain?

rdmueller · 2021-03-23T16:06:29Z

ok. I will try to test it... hold on...

rdmueller · 2021-03-23T16:27:47Z

hm. I cloned docToolchain and added to the file src/docs/manual.adoc the following lines:

slide::Demo.pptx[slideNumber=1]

excel::Sample.xlsx[sheetName=Werte]

I then did a ./gradlew generateHTML and checked the resulting build/docs/html5/manual.html - didn't work :-(

uniqueck · 2021-04-02T00:30:41Z

Hi guys,

please use the version 0.0.1-alpha.2 this is the latest version. I have to invest some time to move away from bintray to maven central.

uniqueck · 2021-04-02T00:31:38Z

scripts/AsciiDocBasics.gradle

+ // See https://github.com/uniqueck/asciidoctorj-office-extension
+ // asciidoctor 'com.uniqueck:asciidoctorj-office-extension:0.0.1-alpha'
+ // https://mvnrepository.com/artifact/org.uniqueck/asciidoctorj-office-extension
+ asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') {


Suggested change

asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') {

asciidoctor (group: 'com.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha.2') {

mattes3 · 2021-04-02T06:28:41Z

Hi @uniqueck Constantin, thanks for the tip and the offer to help, appreciate this!

I tried to use the version that you suggested but unfortunately, it is not in the Maven jcenter repository. See here: https://mvnrepository.com/artifact/org.uniqueck/asciidoctorj-office-extension

Could you have a look, why this is so?

uniqueck · 2021-04-02T08:25:28Z

Hi @mattes3, i realize this also yesterday for my example repostiory. I don't know why this is only for this extension a problem. As a workaround I added this following to the repositories sections.

maven { url "https://dl.bintray.com/uniqueck/asciidoctorj" }

Please also accept the suggested code above, because the groupId differs between this versions.

uniqueck · 2021-04-02T08:26:32Z

so, it seems that the plugin brings its own dependencie to asciidoctorj along.

Can you please try to specify the dependency as follows:
    asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') {
        exclude group: 'org.asciidoctor', module: 'asciidoctorj'
    }
this turns the tests at least to green, but I don't know if the plugin then still works.

I check this and define it as a provided dependency.

mattes3 · 2021-04-07T11:24:53Z

@uniqueck Hi Constantin, I have made your changes but the build still breaks. Can you have a look?

rdmueller · 2021-04-07T11:41:01Z

    > Could not resolve all files for configuration ':asciidoctor'.
       > Could not find com.uniqueck:asciidoctorj-office-extension:0.0.1-alpha.2.
         Searched in the following locations:
           - https://jcenter.bintray.com/com/uniqueck/asciidoctorj-office-extension/0.0.1-alpha.2/asciidoctorj-office-extension-0.0.1-alpha.2.pom

uniqueck · 2021-04-07T22:00:05Z

This extension is now in maven central available. Please have a look at the issue #556 for more details. You have to change the groupId to de.uniqueck.asciidotorj.extensions and the first new release version is 0.1.0. The reference to bintray and jcenter can be removed. Let me know if this helps.

This reverts commit 83347cb

mattes3 · 2021-04-08T11:46:14Z

Now the tests run fine.
Afterwards, I tried what you, Ralf, tried above:

added to the file src/docs/manual.adoc the following lines:

slide::Demo.pptx[slideNumber=1]

I then did a ./gradlew generateHTML and checked the resulting build/docs/html5/manual.html - didn't work :-( The line that I inserted did not make Asciidoctor include the image but the line simply appeared in my output HTML document.

@uniqueck, could you check if you can find out why nothing happens?

uniqueck · 2021-04-08T22:44:06Z

This extension needs asciidoctorj 2.1.0. I have to check if i can downgrade these dependencies. For the meanwhile you can check this working example. https://github.com/uniqueck/asciidoctorj-extension-gradle-example

uniqueck · 2021-04-08T22:44:49Z

@rdmueller is it for doctoolchain possible to update asciidoctorj to a version greater or equal to 2.1.0?

rdmueller · 2021-04-10T18:43:22Z

@uniqueck - that's on my list. But not for the 1.3.x version - only for the 2.0.x which is currently under heavy developtment (ng-branch)

mh182 · 2023-04-12T14:42:55Z

We upgraded to asciidoctorj 2.5.7.

The question is if this feature is still needed/requested. Otherwise I would close the PR until someone needs it.

rdmueller · 2023-05-04T10:36:25Z

The question is if this feature is still needed/requested. Otherwise I would close the PR until someone needs it.

it is still a great feature, let's see if @uniqueck will find some time to work on it.

uniqueck · 2023-05-04T22:22:05Z

What is open? Is there a bug?

mattes3 · 2023-05-05T05:43:03Z

In 2021, this was important to my clients. Now in 2023, it would still be great to have.

mh182 · 2023-05-05T09:06:24Z

What is open? Is there a bug?

Probably nothing from the plugin side. This PR was started by @mattes3 but was blocked since docToolchain used an outdated asciidoctorj plugin. Now we upgraded to the latest asciidoctorj plugin and I wanted to know if someone is willing to stand up and finish it.

Since there is not much code (know-how) in the PR I would rather close it than people believing someone is working on the feature but in reality nothing happens.

uniqueck · 2023-05-05T15:16:11Z

So are we sure that all is working as expected?

rdmueller · 2023-05-05T16:18:29Z

@uniqueck , no I guess nobody has tested it yet. I thought there are still things to change/implement after we've uodated the asciidoctor version.

Afaik, the powerpoint support by this plugin is better than what we currently have (works on linux). So I still think this plugin would be nice to have...

uniqueck · 2023-05-05T18:18:12Z

Ok I will check this and ask for some help if I stuck.

uniqueck · 2023-05-06T10:38:27Z

Ok I'm completely lost in this gradle stuff, where I have to declare external dependencies for my extension, so that the asciidoctorj task register thie extension and I can use the slide block macro. I thought the goal of doctoolchain ng was, make all a little bit simpler.

I tried to defined a configuration for asciidcoctorExtensions and add this configuration to dependencies with my office extension.
I the script AsciiDocBasics I added configuration 'asciidoctorExtensions', but no effect.

uniqueck · 2023-05-06T10:40:26Z

The second thing I realized, is that the PR points to the wrong target branch, or I'm wrong? I need asciidoctorj 2.x for this extension, so we have to relocate it to the ng branch.

I think we have to provide a documentation part, how someone can add an own asciidoctorj extension for dtcw.

Added Office plugin for Asciidoctorj

6e3f5fd

mattes3 mentioned this pull request Mar 17, 2021

Add direct access to PPT slides using asciidoctorj-office-extension #556

Open

Excluded the dependency to a concrete version of Asciidoctor.

fb96812

uniqueck requested changes Apr 2, 2021

View reviewed changes

Added second repository but the build still fails.

83347cb

mattes3 added 2 commits April 8, 2021 10:29

Revert "Added second repository but the build still fails."

ca010e9

This reverts commit 83347cb

Added new version of asciidoctorj-office-extension

eab396e

rdmueller marked this pull request as draft September 10, 2022 12:17

rdmueller changed the title ~~Added Office plugin for Asciidoctorj~~ WIP: Added Office plugin for Asciidoctorj Jan 14, 2023

mh182 linked an issue Apr 12, 2023 that may be closed by this pull request

Add direct access to PPT slides using asciidoctorj-office-extension #556

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Added Office plugin for Asciidoctorj #557

WIP: Added Office plugin for Asciidoctorj #557

mattes3 commented Mar 17, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

mattes3 commented Mar 23, 2021

rdmueller commented Mar 23, 2021

mattes3 commented Mar 23, 2021

rdmueller commented Mar 23, 2021

rdmueller commented Mar 23, 2021

uniqueck commented Apr 2, 2021

uniqueck Apr 2, 2021

mattes3 commented Apr 2, 2021

uniqueck commented Apr 2, 2021

uniqueck commented Apr 2, 2021 •

edited

mattes3 commented Apr 7, 2021

rdmueller commented Apr 7, 2021

uniqueck commented Apr 7, 2021

mattes3 commented Apr 8, 2021

uniqueck commented Apr 8, 2021

uniqueck commented Apr 8, 2021

rdmueller commented Apr 10, 2021

mh182 commented Apr 12, 2023

rdmueller commented May 4, 2023

uniqueck commented May 4, 2023

mattes3 commented May 5, 2023

mh182 commented May 5, 2023

uniqueck commented May 5, 2023

rdmueller commented May 5, 2023

uniqueck commented May 5, 2023

uniqueck commented May 6, 2023

uniqueck commented May 6, 2023 •

edited

	asciidoctor (group: 'org.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha') {
	asciidoctor (group: 'com.uniqueck', name: 'asciidoctorj-office-extension', version: '0.0.1-alpha.2') {

WIP: Added Office plugin for Asciidoctorj #557

Are you sure you want to change the base?

WIP: Added Office plugin for Asciidoctorj #557

Conversation

mattes3 commented Mar 17, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

rdmueller commented Mar 22, 2021

mattes3 commented Mar 23, 2021

rdmueller commented Mar 23, 2021

mattes3 commented Mar 23, 2021

rdmueller commented Mar 23, 2021

rdmueller commented Mar 23, 2021

uniqueck commented Apr 2, 2021

uniqueck Apr 2, 2021

Choose a reason for hiding this comment

mattes3 commented Apr 2, 2021

uniqueck commented Apr 2, 2021

uniqueck commented Apr 2, 2021 • edited

mattes3 commented Apr 7, 2021

rdmueller commented Apr 7, 2021

uniqueck commented Apr 7, 2021

mattes3 commented Apr 8, 2021

uniqueck commented Apr 8, 2021

uniqueck commented Apr 8, 2021

rdmueller commented Apr 10, 2021

mh182 commented Apr 12, 2023

rdmueller commented May 4, 2023

uniqueck commented May 4, 2023

mattes3 commented May 5, 2023

mh182 commented May 5, 2023

uniqueck commented May 5, 2023

rdmueller commented May 5, 2023

uniqueck commented May 5, 2023

uniqueck commented May 6, 2023

uniqueck commented May 6, 2023 • edited

uniqueck commented Apr 2, 2021 •

edited

uniqueck commented May 6, 2023 •

edited