Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stariver to fix #461 #466

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

PiDanShouRouZhouXD
Copy link
Collaborator

@PiDanShouRouZhouXD PiDanShouRouZhouXD commented May 19, 2024

修改程序,通过用户名密码的方式获取token,每次启动检测/OCR的时候自动更新以修复 #461
detector新增了自动缩小图像的功能,以增加上传速度 #456

@PiDanShouRouZhouXD PiDanShouRouZhouXD changed the title update stariver to fix #641 update stariver to fix #461 May 19, 2024
@PiDanShouRouZhouXD
Copy link
Collaborator Author

@dmMaze 老哥检查一下,可以的话就merge了。

@dmMaze
Copy link
Owner

dmMaze commented May 19, 2024

你有读写权限了 stariver 和 sakura 这些局部修改你自己跑一遍看下大概没有问题就可以直接 push 了,有问题我也会看看,而且我也申请没有 stariver 的 token 啊
这个点个 checkbox 刷新 token 的逻辑有点怪,我觉得可以这样你看行不行:

  1. 只在向服务器发请求那个函数开头尝试获取 token
  2. 获取 token 前检查 self.register_password, self.register_username (初值为 None) 这两个值是否和 params 里的两个一致,不一致就请求获取新 token,然后 register_password, register_username 都更新到对应值

@PiDanShouRouZhouXD
Copy link
Collaborator Author

你有读写权限了 stariver 和 sakura 这些局部修改你自己跑一遍看下大概没有问题就可以直接 push 了,有问题我也会看看,而且我也申请没有 stariver 的 token 啊
这个点个 checkbox 刷新 token 的逻辑有点怪,我觉得可以这样你看行不行:

  1. 只在向服务器发请求那个函数开头尝试获取 token
  2. 获取 token 前检查 self.register_password, self.register_username (初值为 None) 这两个值是否和 params 里的两个一致,不一致就请求获取新 token,然后 register_password, register_username 都更新到对应值

好,我改完了就直接merge了

@PiDanShouRouZhouXD PiDanShouRouZhouXD merged commit 7c71844 into dmMaze:dev May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants