Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update the install script #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wilzbach
Copy link
Member

If we go with this, imho we should reopen #274 (config file) and allow people to opt-out of this.
There are certainly use cases in which always updating the installer can be annoying, especially if you use the install script with an already installed compiler this will add a few seconds extra to every activation.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Copy link
Member

@MartinNowak MartinNowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit too blunt and also unexpected for users. I'd be in favor of some regular (weekly) etag based check.
Also auto-updates should only be done if they're verifyable (gpg available).
Another point, atm. we have to be backwards compatible with the server layouts, but we shouldn't negligently drop backwards compatibility just b/c of auto-updates.

@wilzbach wilzbach added the WIP label Apr 5, 2018
@wilzbach
Copy link
Member Author

wilzbach commented Apr 5, 2018

I'd be in favor of some regular (weekly) etag based check.

Where can we store the etag?
Something like ${XDG_CACHE_HOME:-$HOME/.cache}/dlang-installer/self-etag ?

This seems a bit too blunt and also unexpected for users.

Fair enough.

@CyberShadow
Copy link
Member

I think this is fine to do when installing a new version.

Currently "install" (with a specific version) does nothing if that version compiler is already installed, and I think that should continue not performing any network activity.

You could also make use of the Last-Modified and If-Modified-Since headers to avoid downloading/installing it if it's up to date. wget has this with its -N switch; for curl, parsing the headers will be necessary.

@AndrewEdwards
Copy link
Contributor

@wilzbach, is it safe to assume that you no longer plan on pursuing this further?

@wilzbach
Copy link
Member Author

wilzbach commented Sep 8, 2020

@wilzbach, is it safe to assume that you no longer plan on pursuing this further?

Well, I'm definitely not actively working on this. Sorry.
FYI: There was a recent attempt on this (#457) that I unfortunately had to revert as it was merged without review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants