Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.ts #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update types.ts #80

wants to merge 2 commits into from

Conversation

yoyos
Copy link

@yoyos yoyos commented Oct 18, 2022

Fixes #79

@yoyos
Copy link
Author

yoyos commented Nov 11, 2022

Didn't test so careful if you approve :)

Copy link

@guilfer-dev guilfer-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes the library compatible with react 18.x, where the child prop is not default

@giulianf
Copy link

No more activity ? can't be approved?

@guilfer-dev
Copy link

No more activity ? can't be approved?

Alternatively while there is no official support, you can just extend the type, similar to what happens in this question

https://stackoverflow.com/questions/40322788/how-to-overwrite-incorrect-typescript-type-definition-installed-via-types-packa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes
6 participants