Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust docs slightly so that behavior of width/height fields is documented more precisely. #18112

Merged
merged 1 commit into from May 2, 2024

Conversation

john-parton
Copy link
Contributor

@john-parton john-parton commented Apr 29, 2024

…ented more precisely.

Trac ticket number

N/A

Branch description

This is a trivial change which adjust the docs regarding the width and height fields for ImageField.

If you do the following:

  1. Save a model with an image field and width/height fields
  2. Modify the underlying file outside of django.
  3. Load the instance from the DB and re-save it.

Then the width/height fields will not be updated. This might seem obvious to a more experienced dev, but the current documentation isn't exactly clear on the behavior.

See discussion: #18070

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@john-parton john-parton changed the title Adjust docs slightly so that behavior of width/height fields is docum… Adjust docs slightly so that behavior of width/height fields is documented more precisely. Apr 29, 2024
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Pushed small edits 👍

@sarahboyce sarahboyce merged commit 914bf69 into django:main May 2, 2024
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants