Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: setup.py -> pyproject.toml #745

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jacobjove
Copy link

Closes #659

@jacobjove jacobjove marked this pull request as draft December 20, 2023 16:18
@Stranger6667
Copy link
Collaborator

I'd vote against having Poetry-specific content in pyproject.toml

@Stranger6667
Copy link
Collaborator

Instead, I'd suggest specifying dependencies as described in the pyproject.toml spec.

@benjaoming
Copy link
Contributor

Nice work @iacobfred 🙏

Agreeing with @Stranger6667, I don't see the current benefit of using Poetry. And even if switching to a tool like this, I would prefer hatch.. but then we have to do a lot of extra work to migrate current Tox-based environment management and CI. Which I think is too much for one changeset.

Would you be able to change to a version of pyproject.toml to be without Poetry and we just use [project.optional-dependencies] like @Stranger6667 linked?

@benjaoming
Copy link
Contributor

@Stranger6667 if we switch to hatch, we can get rid of the setup.py-based builder alltogether. Would you be good with that?

For instance like this:

https://github.com/django-wiki/django-wiki/blob/cf980084d222775458c976703972b7edca9aa07f/pyproject.toml#L67

and

https://github.com/django-wiki/django-wiki/blob/cf980084d222775458c976703972b7edca9aa07f/pyproject.toml#L84-L85

We could also use hatch to get rid of the Makefile and MANIFEST.in.

@Stranger6667
Copy link
Collaborator

@benjaoming Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools should not be part of the dependencies
3 participants