add CurrencyField for Django Rest Framework #663
Conversation
limonrojo-nm
commented
Mar 23, 2022
limonrojo-nm
commented
- Introduces the corresponding DRF Field: CurrencyField
- modifes register_money_field into register_drf_fields
- Introduces the corresponding DRF Field - modifes register_money_field into register_drf_fields
There was a problem hiding this comment.
Hey! Sorry that the PR has been stuck for so long. I'm one of the maintainers, but I don't use DRF. I believe that there isn't anything problematic here, the former behavior is retained, and only new behavior is added.
It should have a test case, though? The recipe could be to 1) add a new Model with a CurrencyField in tests/testapp.models and 2) add a simple test case to tests/contrib/test_django_rest_framework borrowing from the patterns already implemented..
https://github.com/django-money/django-money/blob/main/tests/testapp/models.py
https://github.com/django-money/django-money/blob/main/tests/contrib/test_django_rest_framework.py
Oh and thanks for the contribution! Unless you beat me to it, I'll add the changelog entry. @Stranger6667 LMK if you have any concerns here.
