Fixed bug in Subscription.api_list bug #1972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqlite3.IntegrityError: NOT NULL constraint failed: djstripe_webhookendpoint.tolerance Fixes #1955
Instead djstripe_settings.WEBHOOK_TOLERANCE, since it was removed (#1967)
* Updated BaseInvoice.retry to accept kwargs This was done so that kwargs can be passed down to Invoice.pay() * Updated Customer.send_invoice method This was done so that kwargs could be passed down to Invoice.pay(). * Formatting fix * Updated docs
If the user passed in status=None, it would not get passed down to Stripe API correctly. None is a valid value for status in this context.
arnav13081994
force-pushed
the
feature/fix_subscription_api_list_bug
branch
from
1cedd23
to
568fa6e
Compare
jleclanche
force-pushed
the
master
branch
5 times, most recently
from
15e04c3
to
8727894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug that was not passing down
status=Nonecorrectly to the Stripe API.status=Noneis a valid value.