Add idempotency to Stripe Create Calls #1909
Open
Commits on Apr 20, 2023
-
-
-
Added SourceTransaction.get_stripe_dashboard_url() method
This was done because Stripe does not expose a separate url to access these objects and they can only be accessed with the Related Source Object
-
-
-
-
Refactored Source object event handler into its own independent handler
This was done because the "Source" event handler was receiving all events of the type source.X.Y which was causing a mismatch between the event type and the target object type. This is why the target object type was explicitly checked as done for the "Charge" event handler.
-
Updated _handle_crud_like_event for SourceTransaction Objects
This was done because newly created Sourcetransaction objects cannot be retrieved as Stripe doesn't allow `retrieve` operation yet. And in order to retrieve by the related "Source" object we need the source to be attached to a "Customer" instance which will not always be the case and can't be known ahead of time as the order of webhooks is unreliable. This is why retrieving the data of the SourceTransaction object was skipped.
-
-
-
-
-
-
-
-
-
Updated the get_idempotency_key function
The function whenever called always creates a new idempotency key. This was done because the older implementation was only suitable for Customer.create() method as was not generic to handle all `create` or `update` calls.
-
Updated Customer.purge() method to not delete the associated idempote…
…ncy_key This was done because in the updated flow we ALWAYS generate a new idempotency_key for a request if one is not provided. The old flow was only applicable for Customer creation with a given user as a subscriber. Besides re-using these keys are pointless after a period of 24 hours anyway.
-
Renamed get_idempotency_key to create_idempotency_key
This was done to better reflect the functionality of the function create_idempotency_key.
-
Added Idempotencykey.update_action_field staticmethod
This is a helper method to update the action model field post object creation with the stripe object's id to ease reference of the idempotency_key used to create or update the stripe object.
-
Added StripeModel.get_or_create_idempotency_key
This was done in order to populate the idempotency_key and use it to make the call on behalf of the user in case they do not provide us with one.
-
Updated StripeModel._api_create to use Idempotency Key object
The _api_create method now does the following: 1) Generated a new Idempotency Key object if not given one. 2) Uses the Idempotency key (from 1)) to make the Stripe API call. 3) Updates the action model field of the Idempotency Key object with the id of the so created Stripe object.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.