Add optional created kwarg to djstripe_sync_models management command
#1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnav13081994
force-pushed
the
feature/add_created_kwarg_to_models_sync
branch
from
d6a1757
to
a39f6d0
Compare
arnav13081994
force-pushed
the
feature/add_created_kwarg_to_models_sync
branch
from
97195f3
to
93cf31e
Compare
`created` optional kwarg will allow dj-stripe users to sync models
after the last sync or after a particulat datetime. This would
be far better than initiating every sync from the beginning
every single time.
This approach was taken as it is very difficult to manage exactly what all models' list calls support the `created` field. And that is why we run `list()` as is and in case the given model doesn't support `created` param we catch and remove it from the kwargs dict and re-run `list()`
arnav13081994
force-pushed
the
feature/add_created_kwarg_to_models_sync
branch
from
93cf31e
to
44baabf
Compare
jleclanche
force-pushed
the
master
branch
5 times, most recently
from
15e04c3
to
8727894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional
createdkwarg to thedjstripe_sync_modelsmanagement command to allow users to specify the datetime they would like to initiate sync from. This is far better than always initiating sync from the beginning.