timemachine: support seeking through log records #45
Conversation
Signed-off-by: Achille Roussel <[email protected]>
|
The implementation is rudimentary, there are worst-case scenarios like stepping back to the previous offset repeatedly would cause a full scan from the start each time; we can figure out optimizations later. I also need to add tests, but I think I want to first modify the |
| @@ -120,6 +157,11 @@ func (r *LogReader) readFrame() (*buffer.Buffer, error) { | |||
| return f, nil | |||
| } | |||
|
|
|||
| var ( | |||
| _ io.Closer = (*LogReader)(nil) | |||
There was a problem hiding this comment.
Any reason why not?
| _ io.Closer = (*LogReader)(nil) | |
| _ io.ReadCloser = (*LogReader)(nil) |
There was a problem hiding this comment.
Because we can't read bytes from the LogReader, the underlying io.Reader isn't exposed.
There was a problem hiding this comment.
Sorry i meant _ io.ReadSeeker = (*LogReader)(nil) (combining this check and the one below)
There was a problem hiding this comment.
Ah yeah we could have combined them, same same 😁
Co-authored-by: Thomas Pelletier <[email protected]>
Following up from conversations with @pelletier and @chriso, and in relation with #43, this PR adds the ability to seek through the log records by implementing
io.Seeker.