DEV: add home-logo-contents plugin outlet #26965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyb-talks
commented
May 10, 2024
Comment on lines
87
to
90
| minimized=@minimized | ||
| logoUrl=this.logoUrl | ||
| logoSmallUrl=this.logoSmallUrl | ||
| showMobileLogo=this.showMobileLogo |
There was a problem hiding this comment.
passing these in so that any additional content can be customized the same way we do here in the standard home-logo.
tyb-talks
force-pushed
the
dev-add-home-logo-content-plugin-outlet
branch
from
99cb3fa
to
4e7bd72
Compare
davidtaylorhq
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new plugin outlet to facilitate upgrading to the glimmer header - this is useful for any widget customizations in themes that use
reopenWidgetto override getters within the home-logo widget that would result in changes of content within the interactive anchor element that makes the entire home-logo section navigate to a specified URL on click.