Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: native zlib support #10243

Merged
merged 14 commits into from May 11, 2024
Merged

refactor: native zlib support #10243

merged 14 commits into from May 11, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented May 3, 2024

Please describe the changes this PR makes and why it should be merged:
#9279 again, but supports both

@didinele didinele requested a review from a team as a code owner May 3, 2024 13:33
@didinele didinele requested review from vladfrangu and iCrawl May 3, 2024 13:33
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 3:28pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 3:28pm

packages/ws/README.md Outdated Show resolved Hide resolved
packages/ws/src/utils/constants.ts Show resolved Hide resolved
Co-authored-by: Jiralite <[email protected]>
packages/ws/src/utils/constants.ts Outdated Show resolved Hide resolved
packages/ws/src/utils/constants.ts Show resolved Hide resolved
packages/ws/src/ws/WebSocketShard.ts Outdated Show resolved Hide resolved
packages/ws/src/ws/WebSocketShard.ts Outdated Show resolved Hide resolved
packages/ws/src/ws/WebSocketShard.ts Outdated Show resolved Hide resolved
@didinele didinele requested a review from vladfrangu May 4, 2024 11:48
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing, not blocking

packages/ws/src/ws/WebSocketShard.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 112 lines in your changes are missing coverage. Please review.

Project coverage is 61.75%. Comparing base (ba6476d) to head (5058304).
Report is 55 commits behind head on main.

Files Patch % Lines
packages/ws/src/ws/WebSocketShard.ts 18.84% 112 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10243      +/-   ##
==========================================
- Coverage   62.35%   61.75%   -0.61%     
==========================================
  Files         209      210       +1     
  Lines       16280    16519     +239     
  Branches     1213     1215       +2     
==========================================
+ Hits        10152    10201      +49     
- Misses       6083     6273     +190     
  Partials       45       45              
Flag Coverage Δ
brokers 63.49% <ø> (ø)
builders 95.77% <ø> (+0.20%) ⬆️
collection 99.32% <ø> (ø)
formatters 99.31% <ø> (ø)
proxy 78.52% <ø> (+3.52%) ⬆️
rest 92.30% <ø> (-0.29%) ⬇️
util 68.86% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.64% <ø> (ø)
website 0.00% <ø> (ø)
ws 51.73% <27.27%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladfrangu vladfrangu added this to the ws 2.0.0 milestone May 4, 2024
Co-authored-by: Superchupu <[email protected]>
@didinele didinele requested a review from SpaceEEC May 8, 2024 10:50
@kodiakhq kodiakhq bot merged commit 20258f9 into main May 11, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the refactor/native-zlib branch May 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

7 participants