Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(brokers): make option props more correct #10242

Merged
merged 3 commits into from May 11, 2024

Conversation

didinele
Copy link
Member

@didinele didinele commented May 3, 2024

BREAKING CHANGE: Classes now take redis client as standalone parameter, various props from the base option interface moved to redis options

BREAKING CHANGE: Classes now take redis client as standalone parameter, various props from the base option interface moved to redis options
@didinele didinele requested a review from a team as a code owner May 3, 2024 13:02
@didinele didinele requested a review from iCrawl May 3, 2024 13:02
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2024 3:51pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 11, 2024 3:51pm

@Jiralite Jiralite modified the milestones: brokers 0.3.0, brokers 0.4.0 May 4, 2024
@didinele didinele requested review from kyranet and SpaceEEC May 8, 2024 10:52
@kodiakhq kodiakhq bot merged commit 393ded4 into main May 11, 2024
7 checks passed
@kodiakhq kodiakhq bot deleted the refactor/move-broker-props branch May 11, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants