Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ClientUser): Add support for setting bot banner #10176

Merged
merged 4 commits into from
Apr 9, 2024
Merged

feat(ClientUser): Add support for setting bot banner #10176

merged 4 commits into from
Apr 9, 2024

Conversation

MinerPL
Copy link
Contributor

@MinerPL MinerPL commented Mar 14, 2024 •
edited by Jiralite

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • This PR changes the library's interface (methods or parameters added)

@MinerPL
feat(discord.js): added support to setting bot banner
1d81765 
added feature to set banner for bot from code level
the function is in the experimental phase of Discord.
@MinerPL MinerPL requested a review from a team as a code owner March 14, 2024 23:31
@vercel Vercel
Copy link

vercel bot commented Mar 14, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 2:04pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 2:04pm

@Jiralite
Copy link
Member

Jiralite commented Mar 14, 2024 •
edited

This is not documented. We only document... documented features. We'll keep this open in hopes in the coming days it will land.

@Jiralite Jiralite marked this pull request as draft March 14, 2024 23:33
@Jiralite Jiralite changed the title feat(discord.js): added support to setting bot banner feat(ClientUser): Add support for setting bot banner Mar 14, 2024
@MinerPL
Copy link
Contributor Author

MinerPL commented Mar 15, 2024

Released a moment ago:
DDevs Post: https://discord.com/channels/613425648685547541/697138785317814292/1218248663869030521
Documentation PR: discord/discord-api-docs#6710

Jiralite
Jiralite previously requested changes Mar 15, 2024
View reviewed changes
packages/discord.js/src/structures/ClientUser.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/ClientUser.js Outdated Show resolved Hide resolved
almeidx
almeidx previously requested changes Mar 15, 2024
View reviewed changes
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
@Jiralite Jiralite dismissed stale reviews from almeidx and themself March 16, 2024 13:52

Resolved.

@Jiralite Jiralite added this to the discord.js 14.16 milestone Apr 9, 2024
@Jiralite Jiralite marked this pull request as ready for review April 9, 2024 14:04
@Azzraya Azzraya mentioned this pull request Jun 4, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jun 4, 2024
Open
@ImPabl0 ImPabl0 mentioned this pull request Jun 4, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jun 4, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 4, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 5, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jun 5, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 5, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jun 6, 2024
Open
This was referenced Jun 7, 2024
Open
Open
@MinerPL MinerPL deleted the discord.js/bot-banner branch June 16, 2024 00:02
@AlexEKinney AlexEKinney mentioned this pull request Jun 16, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 16, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 16, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jun 17, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 17, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jun 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 18, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 18, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 19, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jun 19, 2024
Open
This was referenced Jun 19, 2024
Open
Open
@Azzraya Azzraya mentioned this pull request Jun 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Jun 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Jun 22, 2024
Open
@ciscoderp ciscoderp mentioned this pull request Jun 23, 2024
Open
@Azzraya Azzraya mentioned this pull request Jun 23, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jun 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.15
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MinerPL @Jiralite @vladfrangu @almeidx