Addition of ClientUtil#webhook #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyroTechniac
suggested changes
Nov 1, 2019
| const id = parts[parts.length - 2]; | ||
| const token = parts[parts.length - 1]; | ||
| if (!id || !token) return null; | ||
| return new WebhookClient(parts[parts.length - 2], parts[parts.length - 1]); |
There was a problem hiding this comment.
Suggested change
| return new WebhookClient(parts[parts.length - 2], parts[parts.length - 1]); | |
| return new WebhookClient(id, token); |
You already have token and id stored in variables, so there's no need to pull from the array again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ClientUtil#webhookfunction which will parse a webhook URL and return aWebhookClient.